Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close open file in sphinx gallery and try deleting it #1847

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Feb 16, 2024

One of the opened NWB files was not closed in a tutorial, which probably prevented it from being deleted in the post-tests cleanup process. Here we try to close and delete the file.

@rly rly enabled auto-merge (squash) February 16, 2024 01:31
@rly rly disabled auto-merge February 16, 2024 01:31
@rly rly changed the base branch from dev to nwb-schema-2.7.0 February 16, 2024 01:31
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90d6b1d) 91.80% compared to head (e248e11) 91.80%.

Additional details and impacted files
@@                Coverage Diff                @@
##           nwb-schema-2.7.0    #1847   +/-   ##
=================================================
  Coverage             91.80%   91.80%           
=================================================
  Files                    27       27           
  Lines                  2625     2625           
  Branches                701      701           
=================================================
  Hits                   2410     2410           
  Misses                  142      142           
  Partials                 73       73           
Flag Coverage Δ
integration 70.89% <ø> (ø)
unit 83.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly requested a review from oruebel February 16, 2024 01:34
@rly rly merged commit 905ef65 into nwb-schema-2.7.0 Feb 16, 2024
23 of 24 checks passed
@rly rly deleted the fix-clean-gallery branch February 16, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants